Fix segmentation fault in singular interface code #39293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code was originally added at 5b8343b#diff-25a6d752c56f179f8798c63d0938849853c5c6d61b21a171aae63bee0f6eb6cfR489 , I can't find relevant discussion. Probably copy paste error. |
|
The change looks good to me (though a review by someone with more Singular experience would be welcome), but could you please also add a regression test? |
|
Documentation preview for this PR (built with commit b9cf5a9; changes) is ready! 🎉 |
mezzarobba
approved these changes
Jan 14, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2025
Fixes sagemath#36101 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39293 Reported by: user202729 Reviewer(s): Marc Mezzarobba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36101
📝 Checklist
⌛ Dependencies